Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make imagePullPolicy configurable #20543

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

daengdaengLee
Copy link
Contributor

@daengdaengLee daengdaengLee commented Oct 26, 2024

Hello! This PR fix #20252 .

Main Changes:
The imagePullPolicy value for ArgoCD image is overwritten based on the value of the IMAGE_PULL_POLICY environment variable when run make manifest-local command.

  • default : Always
  • example for override : IMAGE_PULL_POLICY=IfNotPresent make manifeset-local

I wanted to use Kustomize but couldn’t find a way, so I wrote custom Go code under the hack folder to perform the above operation. (hack/update-manifests-imagepullpolicy)

Minor Changes:
The default imagePullPolicy values were modified according to the following rules.

  • Always : for latest version image (ArgoCD image)
  • IfNotPresent : for version specific image
    Most settings already follow these rules, but there were a few that did not. If these exceptions were intentional, please let me know, and I will revert them to their original state.

Thank you in advance for the review.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

* Always : for latest image
* IfNotPresent : for version specific image

Signed-off-by: daengdaengLee <[email protected]>
@daengdaengLee daengdaengLee requested a review from a team as a code owner October 26, 2024 13:19
Copy link

bunnyshell bot commented Oct 26, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@daengdaengLee daengdaengLee marked this pull request as draft October 26, 2024 13:19
Signed-off-by: daengdaengLee <[email protected]>
Signed-off-by: daengdaengLee <[email protected]>
Signed-off-by: daengdaengLee <[email protected]>
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@16e7517). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20543   +/-   ##
=========================================
  Coverage          ?   55.11%           
=========================================
  Files             ?      324           
  Lines             ?    55088           
  Branches          ?        0           
=========================================
  Hits              ?    30364           
  Misses            ?    22101           
  Partials          ?     2623           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daengdaengLee daengdaengLee marked this pull request as ready for review October 27, 2024 07:32
@daengdaengLee
Copy link
Contributor Author

Hello, @pasha-codefresh , @crenshaw-dev .
Could you review this PR, please?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use IfNotPresent in imagePullPolicy of manifests
1 participant