-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make imagePullPolicy configurable #20543
Open
daengdaengLee
wants to merge
5
commits into
argoproj:master
Choose a base branch
from
daengdaengLee:issue-20252
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+144
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Always : for latest image * IfNotPresent : for version specific image Signed-off-by: daengdaengLee <[email protected]>
Signed-off-by: daengdaengLee <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Signed-off-by: daengdaengLee <[email protected]>
6 tasks
Signed-off-by: daengdaengLee <[email protected]>
Signed-off-by: daengdaengLee <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20543 +/- ##
=========================================
Coverage ? 55.11%
=========================================
Files ? 324
Lines ? 55088
Branches ? 0
=========================================
Hits ? 30364
Misses ? 22101
Partials ? 2623 ☔ View full report in Codecov by Sentry. |
Hello, @pasha-codefresh , @crenshaw-dev . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR fix #20252 .
Main Changes:
The
imagePullPolicy
value for ArgoCD image is overwritten based on the value of theIMAGE_PULL_POLICY
environment variable when runmake manifest-local
command.IMAGE_PULL_POLICY=IfNotPresent make manifeset-local
I wanted to use Kustomize but couldn’t find a way, so I wrote custom Go code under the hack folder to perform the above operation. (
hack/update-manifests-imagepullpolicy
)Minor Changes:
The default
imagePullPolicy
values were modified according to the following rules.Most settings already follow these rules, but there were a few that did not. If these exceptions were intentional, please let me know, and I will revert them to their original state.
Thank you in advance for the review.
Checklist: